Crash when a parent item is dragged into its list of children

[ravenfish]

When attempting to drag advantages into a parent item, I accidentally clicked the parent item itself and dragged it into the middle of the list of child advantages. The program froze for a few seconds and then crashed. I presume trying to make a trait the parent of itself led to an infinite loop. Setting the program to refuse to make a trait its own child, rather than trying to do so and crashing, might be worth doing.

[Armin]

Originally Posted by ravenfish

When attempting to drag advantages into a parent item, I accidentally clicked the parent item itself and dragged it into the middle of the list of child advantages. The program froze for a few seconds and then crashed. I presume trying to make a trait the parent of itself led to an infinite loop. Setting the program to refuse to make a trait its own child, rather than trying to do so and crashing, might be worth doing.

Thanks for reporting this, I will look into it.

There is indeed code to disallow a parent from being made its own child. Perhaps that's not working properly (which seems likely). I'm sure that's annoying, but there is no reason to be rude about it.

[ravenfish]

Originally Posted by Armin

There is indeed code to disallow a parent from being made its own child. Perhaps that's not working properly (which seems likely). I'm sure that's annoying, but there is no reason to be rude about it.

I'm sorry if I was rude. I certainly did not intend to be; I merely thought it would be helpful to report the bug. It is easy enough to work around the problem (indeed, I have used your excellent program for a long time without noticing this problem's existence).

For what it's worth, when assigning an item a parent through the right-click menu, or from "Traits" on the main menu, the item itself does not appear on the list of possible parents, so the checks are clearly working at least to a degree.

[Armin]

Thank you. Reporting the bug was absolutely helpful, and I appreciate it. It was your last sentence, especially the "worth doing" bit, that gave me the feeling of rudeness. I apologize if my reading of it was harsher than it was intended.

I have now looked, and yes, there is indeed a problem with the handling of drag-and-drop when it comes to checking the parent/child chain for items.

I'm working to figure out a fix now.

[ravenfish]

Originally Posted by Armin

Thank you. Reporting the bug was absolutely helpful, and I appreciate it. It was your last sentence, especially the "worth doing" bit, that gave me the feeling of rudeness.

I had meant to imply "is a candidate for attention, but I have no way of knowing how much effort it would take to properly resolve and where it should stand on the priorities list compared to other issues of which I may be unaware". I realize, on reflection, that my phrasing could have been better.

[Armin]

Originally Posted by ravenfish

I had meant to imply "is a candidate for attention, but I have no way of knowing how much effort it would take to properly resolve and where it should stand on the priorities list compared to other issues of which I may be unaware". I realize, on reflection, that my phrasing could have been better.

Thanks, I see where you're coming from. We're all good.

I'm working on the issue right now.

[Armin]

I think I've fixed it, and made the process more robust. Should be in the next release.