Dungeon Fantasy Remove Unnecessary traits not removing some equipment?

[Peter V. Dell'Orto]

I'm having an issue with the GURPS Dungeon Fantasy Remove Unnecessary Traits.gdf.

Basically, it's not actually deleting everything it should. For example, some firearms are still there (Blunderbuss, 8G for example), some odd equipment modifiers are still there . . . they're flagged for deletion in the Remove gdf but they don't actually get removed.

Here is the text of the Data Set I use:
files("GURPS Basic Set 4th Ed.--Characters.gdf", "GURPS Magic 4e.gdf", "%sys%\Worldbooks\GURPS Dungeon Fantasy 1 - Adventurers.gdf", "%sys%\Worldbooks\GURPS Dungeon Fantasy 3 - Next Level.gdf", "%sys%\Worldbooks\GURPS Dungeon Fantasy 4 - Sages.gdf", "%sys%\Worldbooks\GURPS Dungeon Fantasy 5 - Allies.gdf", "%user%\GURPS Dungeon Fantasy 11 - Power-Ups.gdf", "%sys%\worldbooks\GURPS Dungeon Fantasy 12 - Ninja.GDF", "%user%\GURPS LT Weapons for DF.gdf", "%user%\Peter's DF Magic Armor Mods.gdf", "%sys%\worldbooks\GURPS Dungeon Fantasy Remove Unnecessary Traits.GDF", "%user%\GURPS Dungeon Fantasy - Pyramid 3-60 - Wizardry Redefined.gdf")

The LT Weapons for DF file is custom, but it's just the weapons from Low-Tech. None of the items that should be deleted are added back in there. Same with the magic armor file. And if I take out my custom files, there are still items that sat "Delete" in the GURPS Dungeon Fantasy Remove Unnecessary Traits.gdf that aren't coming out.

I've gone as far as:

- re-running the Data File Update.
- taking out all GDF files except Basic, DF1, and Remove Unnecessary.
- taking out all GDF files except Basic and Remove Unnecessary.

Anyone know what is causing this? It's getting very frustrating having players edit their characters, shop for gear and whatnot, and send me characters with stuff specifically flagged for deletion.

[Armin]

Hi, Peter,

I took one case from your post, "Blunderbuss, 8G", and looked at that.

I am looking at the file from "Description=04/01/2013." but the one from "Description=12/12/2011." appears identical for this case.

In the case of this item, it is not actually being removed because it's not marked for removal under any of the specifications that I can see.

I'm guessing that it's intended to be removed by #DeleteCat EQ, "Firearms - Pistols & SMGs", but the actual category in Basic Set is Basic Set - Firearms - Pistols & SMGs.

I'm gonna guess the Basic Set categories were changed at some point after the Removal file was created, and the Removal file wasn't updated to match.

So, basically, the Removal file needs to be updated with the updated categories. I suspect this may be the issue with the other items you're seeing as well.

[Peter V. Dell'Orto]

Originally Posted by Armin

I'm guessing that it's intended to be removed by #DeleteCat EQ, "Firearms - Pistols & SMGs", but the actual category in Basic Set is Basic Set - Firearms - Pistols & SMGs.

That makes sense. I'll make some changes when I get some spare time today and see if it works. If so, I'll upload a copy of the GDF here so people can check my work.

[Peter V. Dell'Orto]

So I quickly tried changing the deleted category, but it didn't work. After a few iterations I just went and removed the * from the *#DeleteEQ lines for the equipment I don't want around. That worked.

I'll check around for any more obvious errors and then see about how to upload the file to the repository at motoslave.

[Armin]

Sorry about the trouble. At least you got something working.

Theoretically we have a data update pending soon*, maybe we can get a fixed file included with that.

Armin

* Eric's pushed for a data update for ages. Roadblock has been me. Hopefully we've cleared that.

[ericbsmith]

Originally Posted by Armin

I'm guessing that it's intended to be removed by #DeleteCat EQ, "Firearms - Pistols & SMGs", but the actual category in Basic Set is Basic Set - Firearms - Pistols & SMGs.

I believe #DeleteCat was only ever intended to removed the category, not the traits within the category. This dated to before GCA cleaned up categories automatically, so if you deleted all the traits in a category you also had to manually delete the category or it would still show up in the drop-down list. So, now, #DeleteCat is basically an obsolete command; the lines of code were never updated because they didn't matter anymore.

To remove the equipment items they must be addressed directly, either by deleting them specifically or using a #DeleteByTag command that catches them (such as those used to delete most of the other higher tech equipment from the lists). I'm guessing that those particular firearms fell through the cracks when I moved from using individual #Delete commands for every piece of equipment to being able to use #DeleteByTag commands to delete most of the equipment by the Tech Level tag, and I just never noticed them for some reason.

I'm guessing that the remaining guns should all be removed. Is there any other anachronistic equipment that needs to be removed?

[ericbsmith]

Originally Posted by Armin

* Eric's pushed for a data update for ages. Roadblock has been me. Hopefully we've cleared that.

I've already started some more clean-up work on the data files, including fixing this particular issue.

[Armin]

Originally Posted by ericbsmith

I believe #DeleteCat was only ever intended to removed the category, not the traits within the category. This dated to before GCA cleaned up categories automatically, so if you deleted all the traits in a category you also had to manually delete the category or it would still show up in the drop-down list. So, now, #DeleteCat is basically an obsolete command; the lines of code were never updated because they didn't matter anymore.

Ah! Yes, I think you're right. Thanks. So easy to forget or overlook things when you don't ever work with them.

And, that also explains why changing the cat didn't work for Peter.

Originally Posted by ericbsmith

I've already started some more clean-up work on the data files, including fixing this particular issue.

Thank you.

Armin

[Peter V. Dell'Orto]

Originally Posted by ericbsmith

I'm guessing that the remaining guns should all be removed. Is there any other anachronistic equipment that needs to be removed?

It mostly just seems like the guns and their ammo.

The DeleteCat issue might explain why I had trouble knocking off some Alchemy-based techniques for my DF game, too.

[ericbsmith]

Originally Posted by Peter V. Dell'Orto

The DeleteCat issue might explain why I had trouble knocking off some Alchemy-based techniques for my DF game, too.

Note that you can use the #DeleteByTag command to delete traits by category (or any other tag), it's just not DeleteCat.

#DeleteByTag Skills, Text IgnoreEmpty, cat = Alchemy