"_Advantage: Weapon Master Damage Bonus" works incorrectly for Bows

[Extrarius]

I was just recently trying to build a character with ST 15, Striking ST 2 (One Attack Only), and the Strongbow perk with Bow at DX+2. All together, that means I can use a ST 19 bow. When I add a ST 19 Reflex bow, the damage is correctly listed as 2d6+2. However, once I add the "_Advantage: Weapon Master Damage Bonus" modifier, the damage only goes up to 2d6+4 instead of the expected 2d6+6.

If I modify my character's strength to be 19, the Bow's damage correctly becomes 2d6+6. With this evidence, it seems like the modifier is using the character's strength instead of the Bow's strength.

Is there any way to fix this? For now, I'm working around it by making a custom modifier that adds a fixed +4 damage, but a more comprehensive solution would be greatly appreciated.

[ericbsmith]

Originally Posted by Extrarius

If I modify my character's strength to be 19, the Bow's damage correctly becomes 2d6+6. With this evidence, it seems like the modifier is using the character's strength instead of the Bow's strength.

That is correct, it is using the Characters ST. This goes back to the earlier days of GCA, before Bows were properly given their own ST score.

Originally Posted by Extrarius

Is there any way to fix this? For now, I'm working around it by making a custom modifier that adds a fixed +4 damage, but a more comprehensive solution would be greatly appreciated.

There is likely a way to fix, but I'm going to have to give it some thought. Weapon Master Damage Bonus is one of the more complex modifiers. Getting it working originally without crashing GCA was almost a miracle, so I'm going to have to do some testing.

[ericbsmith]

So after some testing I believe I have this working as intended now:

[MODIFIERS]
<Bow Quality>
_Advantage: Weapon Master Damage Bonus, +0, shortname(Weapon Master Damage Bonus), group(Bow Quality),_
	gives(_
			=+(_
				$if(owner::weaponst > 0 _
					THEN @textindexedvalue($modetag(dmg), ("thr", $solver(@basethdice(owner::weaponst))), ("sw", $solver(@baseswdice(owner::weaponst))), ELSE $solver(owner::dmg)) _
					ELSE @textindexedvalue($modetag(dmg), ("thr", owner::basethdice), ("sw", owner::baseswdice), ELSE $solver(owner::dmg)) _
				) * @if($modetag(charskillscore) > ST:DX+1 _
					THEN 2 _
					ELSE @if($modetag(charskillscore) = ST:DX+1 _
						THEN 1 _
						ELSE 0 _
						) _
					)_
				) to owner::damage$ ListAs "Weapon Master Damage Bonus" _
		)

[Extrarius]

Thank you for your help once again